Skip to content

[CI test] Use liberal VN for TLS indirects #73195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EgorBo wants to merge 2 commits into from
Closed

[CI test] Use liberal VN for TLS indirects #73195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf756bc
Use liberal vn for tls indirects
EgorBo Aug 1, 2022
28f79ef
test
EgorBo Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8735,15 +8735,6 @@ void Compiler::fgValueNumberTree(GenTree* tree)
ValueNumPair op1VNPx;
vnStore->VNPUnpackExc(tree->AsOp()->gtOp1->gtVNPair, &op1VNP, &op1VNPx);

// If we are fetching the array length for an array ref that came from global memory
// then for CSE safety we must use the conservative value number for both
//
if (tree->OperIsArrLength() && ((tree->AsOp()->gtOp1->gtFlags & GTF_GLOB_REF) != 0))
{
// use the conservative value number for both when computing the VN for the ARR_LENGTH
op1VNP.SetBoth(op1VNP.GetConservative());
}

tree->gtVNPair =
vnStore->VNPWithExc(vnStore->VNPairForFunc(tree->TypeGet(), vnf, op1VNP), op1VNPx);
}
Expand Down Expand Up @@ -10421,6 +10412,26 @@ void Compiler::fgValueNumberAddExceptionSetForIndirection(GenTree* tree, GenTree
vnStore->VNExcSetSingleton(vnStore->VNForFunc(TYP_REF, VNF_NullPtrExc, vnpBaseNorm.GetConservative())));
}

VNFuncApp func;
if (vnStore->GetVNFunc(vnpBaseNorm.GetConservative(), &func) &&
(func.m_func == VNF_GetsharedGcthreadstaticBaseNoctor))
{
switch (func.m_func)
{
case VNF_GetgenericsGcthreadstaticBase:
case VNF_GetgenericsNongcthreadstaticBase:
case VNF_GetsharedGcthreadstaticBase:
case VNF_GetsharedNongcthreadstaticBase:
case VNF_GetsharedGcthreadstaticBaseNoctor:
case VNF_GetsharedNongcthreadstaticBaseNoctor:
case VNF_GetsharedGcthreadstaticBaseDynamicclass:
case VNF_GetsharedNongcthreadstaticBaseDynamicclass:
tree->gtVNPair.SetConservative(tree->gtVNPair.GetLiberal());
break;
default:
break;
}
}
// Add the NullPtrExc to "tree"'s value numbers.
tree->gtVNPair = vnStore->VNPWithExc(tree->gtVNPair, excChkSet);
}
Expand Down