Skip to content

[wasm] Update javascript API usage in samples and tests #73367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maraf merged 12 commits into from
Aug 10, 2022
Merged

[wasm] Update javascript API usage in samples and tests #73367

maraf merged 12 commits into from
Aug 10, 2022

Conversation

@maraf
Copy link
Member

@maraf maraf commented Aug 4, 2022

  • Use createDotnetRuntime with object instead of callback where possible.
  • Replace bind_static_method with getAssemblyExports.

@maraf maraf added this to the 7.0.0 milestone Aug 4, 2022
@maraf maraf self-assigned this Aug 4, 2022
@maraf
Copy link
Member Author

maraf commented Aug 4, 2022

/azp run runtime-wasm

@ghost
Copy link

ghost commented Aug 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use createDotnetRuntime with object instead of callback where possible.
  • Replace bind_static_method with getAssemblyExports.
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Aug 4, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Aug 4, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf mentioned this pull request Aug 4, 2022
Merged
@maraf
Copy link
Member Author

maraf commented Aug 4, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara reviewed Aug 5, 2022
View reviewed changes
pavelsavara
pavelsavara reviewed Aug 5, 2022
View reviewed changes
pavelsavara
pavelsavara reviewed Aug 5, 2022
View reviewed changes
@maraf
Copy link
Member Author

maraf commented Aug 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 8, 2022

Pull request contains merge conflicts.

@maraf
Merge remote-tracking branch 'upstream/main' into WasmUseObjectInstea…
cdc8212 
…dOfFunctionInCreateDotnetRuntime

# Conflicts:
#	src/mono/sample/wasm/browser-eventpipe/main.js
#	src/mono/sample/wasm/browser-profile/main.js
@maraf
Copy link
Member Author

maraf commented Aug 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 8, 2022

Comment was made before the most recent commit for PR 73367 in repo dotnet/runtime

@maraf maraf marked this pull request as ready for review August 8, 2022 10:36
@maraf
Copy link
Member Author

maraf commented Aug 8, 2022

The debugger-driver.html still has a bind_static_method for calls that pass method from C# as part of the tests. I'll address these in a separate PR.

@maraf
Copy link
Member Author

maraf commented Aug 8, 2022

/azp run runtime-wasm

@maraf maraf requested a review from pavelsavara August 8, 2022 10:37
@azure-pipelines
Copy link

azure-pipelines bot commented Aug 8, 2022

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maraf @ilonatommy
Fix debugger breakpoint tests
8dc3536 
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
@maraf
Copy link
Member Author

maraf commented Aug 9, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

Pull request contains merge conflicts.

@maraf
Merge remote-tracking branch 'upstream/main' into WasmUseObjectInstea…
3c3a190 
…dOfFunctionInCreateDotnetRuntime

# Conflicts:
#	src/mono/sample/wasm/browser-mt-eventpipe/Program.cs
#	src/mono/sample/wasm/browser-mt-eventpipe/main.js
@maraf
Copy link
Member Author

maraf commented Aug 9, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Aug 10, 2022

One debugger test timed out on runtime-staging, but passed on runtime-wasm.

@maraf maraf merged commit 30c1c2c into dotnet:main Aug 10, 2022
@maraf maraf deleted the WasmUseObjectInsteadOfFunctionInCreateDotnetRuntime branch August 10, 2022 09:45
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@thaystg thaystg Awaiting requested review from thaystg

@radical radical Awaiting requested review from radical

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf @pavelsavara