Skip to content

[Android] Remove BROKEN_CLOCK_SOURCE define on Android #73489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 2 commits into from
Aug 9, 2022
Merged

[Android] Remove BROKEN_CLOCK_SOURCE define on Android #73489

akoeplinger merged 2 commits into from
Aug 9, 2022

Conversation

@steveisok
Copy link
Member

@steveisok steveisok commented Aug 5, 2022

Fixes #58737

@steveisok steveisok requested a review from akoeplinger August 5, 2022 18:49
@ghost ghost added the area-VM-meta-mono label Aug 5, 2022
@ghost ghost assigned steveisok Aug 5, 2022
@akoeplinger akoeplinger changed the title [Android][iOS] Remove BROKEN_CLOCK_SOURCE define on Android and iOS [Android][iOS] Remove BROKEN_CLOCK_SOURCE define on Android Aug 9, 2022
@akoeplinger
Copy link
Member

akoeplinger commented Aug 9, 2022

CLOCK_MONOTONIC is available on ios 10+, but not pthread_condattr_setclock, see #58701 (comment)

So we would want to use pthread_cond_timedwait with a CLOCK_MONOTONIC argument on Apple.

@akoeplinger
Copy link
Member

akoeplinger commented Aug 9, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 9, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger akoeplinger changed the title [Android][iOS] Remove BROKEN_CLOCK_SOURCE define on Android [Android] Remove BROKEN_CLOCK_SOURCE define on Android Aug 9, 2022
@akoeplinger
Copy link
Member

akoeplinger commented Aug 9, 2022

Failures are unrelated

@akoeplinger akoeplinger merged commit 136e29f into dotnet:main Aug 9, 2022
@akoeplinger akoeplinger deleted the remove-broken-clock-droid branch August 9, 2022 18:55
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees

@steveisok steveisok

Labels

area-VM-meta-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revise pthread_condattr_setclock on Android

2 participants

@steveisok @akoeplinger