Skip to content

JIT: Fix alignment insertion assuming only emitForceNewIG can create new IGs #73518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakobbotsch wants to merge 1 commit into from
Closed

JIT: Fix alignment insertion assuming only emitForceNewIG can create new IGs #73518

jakobbotsch wants to merge 1 commit into from

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Aug 6, 2022

Issue I noticed over in #73365.
emitNewInstrAlign can create new IGs for other reasons than emitForceNewIG, e.g. if the current IG cannot fit another instrDesc or if we have reached the limit on the number of instructions in the current IG (255).

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 6, 2022
@jakobbotsch jakobbotsch changed the title Fix alignment insertion assuming only emitForceNewIG can create new IGs JIT: Fix alignment insertion assuming only emitForceNewIG can create new IGs Aug 6, 2022
@ghost ghost assigned jakobbotsch Aug 6, 2022
@ghost
Copy link

ghost commented Aug 6, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue I noticed over in #73365.
emitNewInstrAlign can create new IGs for other reasons than emitForceNewIG, e.g. if the current IG cannot fit another instrDesc or if we have reached the limit on the number of instructions in the current IG (255).

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this pull request Aug 6, 2022
Merged
@jakobbotsch jakobbotsch added this to the 7.0.0 milestone Aug 6, 2022
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Aug 6, 2022

I realize there is emitCheckAlignFitInCurIG now, but it does not handle the 255 case (but maybe this is unreachable as we will reach the size limit before?). I'll just close this.

@jakobbotsch jakobbotsch closed this Aug 6, 2022
This was referenced Aug 8, 2022
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@jakobbotsch