Get rid of more .NET Nativisms #73612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is TypeLoadException, same as missing TypeRef. Not sure why this was MME.
ghost
added
the
Member
I agree that this has no fugure. I think it is fine to delete it in this PR. |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69998.
Fixes #69746.
Might be better to review individual commits.
We have a couple places that also catch MissingMetadataException. This is a .NET Nativism where a type can:
Situation 2 can lead to things like: accessing
Type.FullNamethrows because we don't have the reflection metadata for it. It cannot happen in NativeAOT and I don't see a way to reconcile this with IL Linker, It probably has no future. I could excise that too if there's interest. Maybe better to do in this pull request,Cc @dotnet/ilc-contrib