DisableRuntimeMarshalling block Vector types
#74612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DisableRuntimeMarshalling is set, the runtime should block an bad-list for blittable types. This doesn't address the case where the P/Invoke is inlined.
MichalStrehovsky
approved these changes
Aug 26, 2022
src/coreclr/tools/Common/TypeSystem/Interop/IL/MarshalHelpers.cs
Outdated
Show resolved
Hide resolved
davidwrighton
approved these changes
Aug 26, 2022
Member
Author
|
@tannergooding Is this a priority to get into .NET 7? The missing part for inlined P/Invokes is still outstanding, but that is invasive enough that that isn't something I'd like for .NET 7, but this part seems safe enough. |
2 tasks
Member
|
@AaronRobinsonMSFT, we've already shipped 3 versions of .NET with this interop "hole", so I don't think its a huge issue if the fix misses .NET 7 as well. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DisableRuntimeMarshallingis set, the runtime should blocka bad-list for blittable types.
This doesn't address the case where the P/Invoke is inlined.
Contributes to #74269
/cc @davidwrighton @dotnet/interop-contrib