Add QuicError.AlpnInUse member #74754
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #73045. This PR adds a new member to the
|
|
Shelving until #74755 is approved |
rzikm
force-pushed
the
73045-QUIC-QuicListener-not-reporting-address-in-use-correctly
branch
from
79793e6 to
575704b
Compare
| <value>A QUIC protocol error was encountered</value> | ||
| </data> | ||
| <data name="net_quic_alpn_in_use" xml:space="preserve"> | ||
| <value>Another QUIC listener is already listening on one of the requested application protocols on the same port.</value> |
There was a problem hiding this comment.
I am a bit confused about the wording of the error. If we ask for multiple ALPNs and one is in use but the second is available -- do we still fail?
There was a problem hiding this comment.
yes, the two ALPN lists must be fully disjoint.
| - ${{ if eq(parameters.platform, 'Linux_musl_x64') }}: | ||
| - ${{ if or(ne(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - (Alpine.314.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-helix-amd64-20220803180115-99b3286 | ||
| - (Alpine.314.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-helix-amd64-20220912172439-e7e8d1c |
There was a problem hiding this comment.
The previous image had an older version of MsQuic which returned INVALID_STATE instead of ALPN_IN_USE
ghost
locked as resolved and limited conversation to collaborators
4 participants
Fixes #73045, closes #74755.
This PR adds a new member to the
QuicErrorenum to allow us to clearly communicate to the user that a QuicListener cannot be started with specified ALPN set because another QuicListener with conflicting ALPNs is already listening on the desired port.