Initialize Volatile value #74959
Merged
Initialize Volatile value #74959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsAdding some instrumentation so that we can debug #74631.
|
cshung
force-pushed
the
public/test-instrumentation
branch
5 times, most recently
from
0cd0d9a to
b5250df
Compare
cshung
force-pushed
the
public/test-instrumentation
branch
from
b5250df to
6b4aee0
Compare
Member
|
We also have a copy for local GC here: https://github.com/dotnet/runtime/blob/main/src/coreclr/gc/env/volatile.h |
AaronRobinsonMSFT
approved these changes
Sep 19, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #74363, we changed the code in
gc.cppsuch thatmemset (&last_ephemeral_gc_info, 0, sizeof (last_ephemeral_gc_info));is replaced bylast_ephemeral_gc_info = {};last_ephemeral_gc_infohas typeVolatile<size_t>and the default constructor ofVolatileleave the underlying value uninitialized, this is causing the issue. In the old code, the volatile field was zero-initialized but in the new code, it isn't.This change added back the default initialization for the volatile field and the issue associated with #74631 is fixed.
All GC code related to this change is reviewed and I confirm volatile is the only issue.