Skip to content

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented Sep 7, 2022

This change fixes #75207.

When we init_heap_segment, we preserve the heap_segment_flags_ma_committed, and before we commit_mark_array_new_seg, we check the flag first and avoid recommitting.

For reviewers, I assumed (i.e. please check):

  • The place I changed in the only call site where we commit for the mark array for regions. The other ones are either not defined under USE_REGIONS, or it is for frozen segments where by design it can never overlap with the region reserved range, and
  • Since frozen segments can never overlap with the reserved range, we should never have a region (or a frozen segment) with the flag heap_segment_flags_ma_pcommitted turned on under USE_REGIONS.

@cshung cshung self-assigned this Sep 7, 2022
@ghost
Copy link

ghost commented Sep 7, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This change fixes #75207.

When we init_heap_segment, we preserve the heap_segment_flags_ma_committed, and before we commit_mark_array_new_seg, we check the flag first and avoid recommitting.

For reviewers, I assumed (i.e. please check):

  • The place I changed in the only call site where we commit for the mark array for regions. The other ones are either not defined under USE_REGIONS, or it is for frozen segments where by design it can never overlap with the region reserved range, and
  • Since frozen segments can never overlap with the reserved range, we should never have a region (or a frozen segment) with the flag heap_segment_flags_ma_pcommitted turned on under USE_REGIONS.
Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

@cshung cshung force-pushed the public/preserve-mark-array-flags branch from 1d9c776 to b20a14f Compare September 22, 2022 20:32
@cshung cshung added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 22, 2022
@cshung cshung mentioned this pull request Sep 30, 2022
@cshung cshung closed this Oct 7, 2022
@cshung cshung deleted the public/preserve-mark-array-flags branch October 7, 2022 00:51
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-GC-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repeated commits for mark array

3 participants