-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update System.Formats.Tar docs #75386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsSync triple slash with the docs reviewed docs: dotnet/dotnet-api-docs#8375
|
|
There were suggestions provided in the dotnet-api-docs PR. Need to backport them here. |
| /// <summary> | ||
| /// Initializes a new <see cref="GnuTarEntry"/> instance with the specified entry type and entry name. | ||
| /// </summary> | ||
| /// <remarks>When creating an instance using the <see cref="GnuTarEntry(TarEntryType, string)"/> constructor, only the following entry types are supported: <see cref="TarEntryType.Directory"/>, <see cref="TarEntryType.HardLink"/>, <see cref="TarEntryType.SymbolicLink"/>, <see cref="TarEntryType.RegularFile"/> <see cref="TarEntryType.BlockDevice"/>, <see cref="TarEntryType.CharacterDevice"/> and <see cref="TarEntryType.Fifo"/>.</remarks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why the remarks section moved up?
| /// Gets or sets the ID of the user that owns the file represented by this entry. | ||
| /// </summary> | ||
| /// <remarks>This field is only supported in Unix platforms.</remarks> | ||
| /// <remarks>This field is only used in Unix platforms.</remarks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This field"... this isn't a field, it's a property.
| { | ||
| /// <summary> | ||
| /// Reads a tar archive from a stream. | ||
| /// Reads a TAR archive from a stream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these tars were made TARs. I very rarely see "tar" capitalized as an acronym, e.g. wikipedia uses "tar" rather than "TAR" when talking about "tar archives":
https://en.wikipedia.org/wiki/Tar_(computing)
We've decided to go a different way?
|
I'll close this and will resubmit when we focus on the docs backporting effort. |
Sync triple slash with the docs reviewed docs: dotnet/dotnet-api-docs#8375