Skip to content

Conversation

@carlossanlop
Copy link
Contributor

Sync triple slash with the docs reviewed docs: dotnet/dotnet-api-docs#8375

@carlossanlop carlossanlop added documentation Documentation bug or enhancement, does not impact product or test code area-System.IO labels Sep 10, 2022
@carlossanlop carlossanlop requested a review from jozkee September 10, 2022 01:32
@carlossanlop carlossanlop self-assigned this Sep 10, 2022
@ghost
Copy link

ghost commented Sep 10, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Sync triple slash with the docs reviewed docs: dotnet/dotnet-api-docs#8375

Author: carlossanlop
Assignees: carlossanlop
Labels:

documentation, area-System.IO

Milestone: -

@carlossanlop
Copy link
Contributor Author

There were suggestions provided in the dotnet-api-docs PR. Need to backport them here.

/// <summary>
/// Initializes a new <see cref="GnuTarEntry"/> instance with the specified entry type and entry name.
/// </summary>
/// <remarks>When creating an instance using the <see cref="GnuTarEntry(TarEntryType, string)"/> constructor, only the following entry types are supported: <see cref="TarEntryType.Directory"/>, <see cref="TarEntryType.HardLink"/>, <see cref="TarEntryType.SymbolicLink"/>, <see cref="TarEntryType.RegularFile"/> <see cref="TarEntryType.BlockDevice"/>, <see cref="TarEntryType.CharacterDevice"/> and <see cref="TarEntryType.Fifo"/>.</remarks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why the remarks section moved up?

/// Gets or sets the ID of the user that owns the file represented by this entry.
/// </summary>
/// <remarks>This field is only supported in Unix platforms.</remarks>
/// <remarks>This field is only used in Unix platforms.</remarks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This field"... this isn't a field, it's a property.

{
/// <summary>
/// Reads a tar archive from a stream.
/// Reads a TAR archive from a stream.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these tars were made TARs. I very rarely see "tar" capitalized as an acronym, e.g. wikipedia uses "tar" rather than "TAR" when talking about "tar archives":
https://en.wikipedia.org/wiki/Tar_(computing)
We've decided to go a different way?

@carlossanlop
Copy link
Contributor Author

I'll close this and will resubmit when we focus on the docs backporting effort.

@carlossanlop carlossanlop deleted the TarDocsUpdate branch October 10, 2022 17:14
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Formats.Tar documentation Documentation bug or enhancement, does not impact product or test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants