Ensure end_gen0_region_space is always computed #76214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsFor various reasons, it is possible that the GC skips the computation of That would lead to bad downstream consequences, for example, in This PR ensures the field
|
cshung
commented
Sep 27, 2022
cshung
commented
Sep 27, 2022
cshung
commented
Sep 27, 2022
cshung
force-pushed
the
public/always-compute-end-space
branch
2 times, most recently
from
275c603 to
4f7bd66
Compare
cshung
force-pushed
the
public/always-compute-end-space
branch
from
4f7bd66 to
416bae1
Compare
Merged
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For various reasons, it is possible that the GC skips the computation of
end_gen0_region_space. For example, if we decided to compact but we never calleddecide_on_compaction_space, we will leave theend_gen0_region_spaceunchanged from its initial value 0.That would lead to bad downstream consequences, for example, in
short_on_end_of_seg, theend_gen0_region_spaceis used to decide whether or not we can satisfy an allocation request or not, having a 0 there will fail the allocation.This PR ensures the field
end_gen0_region_spaceis always computed during a GC.