Do not produce full-width local field stores for normalize-on-store locals #76549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocals The underlying stack location must always remain normalized.
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakobbotsch
approved these changes
Oct 3, 2022
Contributor
Author
Contributor
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Oct 5, 2022
…-store locals (dotnet#76549)" This reverts commit dd6696a.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A full-width local field store may leave the upper bits of the 4-byte stack location denormalized.
Fixes #76546.
Going with the "shallow" fix (no asserts, etc) in the interest of unblocking the CI.
We're expecting TP losses, negating some of the wins from #76155.