-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add linker to area owners #77983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linker to area owners #77983
Conversation
Add a new area-tools-linker and assign myself as the lead and @sbomer as technical expert
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsAdd a new area-tools-linker and assign myself as the lead and @sbomer as technical expert
|
sbomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if @vitek-karas wants to be added to the list.
|
Added Vitek as well |
|
You'll presumably want to label whatever you can (transferred issues and any PRs) and then ask Drew to retrain the labeler. |
| | area-System.Xml | @jeffhandley | @dotnet/area-system-xml | | | ||
| | area-Threading-mono | @SamMonoRT | @lambdageek | | | ||
| | area-TieredCompilation-coreclr | @mangod9 | @kouvel | | | ||
| | area-Tools-ILLink | @agocke | @sbomer | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you introduce @dotnet/area-illink alias, it would help to tag all interested folks ad hoc as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have @dotnet/linker-contrib. I just renamed it to @dotnet/illink-contrib.
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@agocke did we validate that the change was valid in the fabricbot portal? I'm seeing that fabricbot automations are not running today, and when I try to load the current configuration in fabricbot for this repo it fails to parse and says that there are no bot configurations tasks for this repository. |
| "mentionees": [ | ||
| "agocke", | ||
| "sbomer", | ||
| "vitek-karas", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this trailing comma is causing problems?
Add a new area-tools-linker and assign myself as the lead and @sbomer as technical expert