Skip to content

Conversation

@agocke
Copy link
Member

@agocke agocke commented Nov 7, 2022

Add a new area-tools-linker and assign myself as the lead and @sbomer as technical expert

Add a new area-tools-linker and assign myself as the lead and @sbomer as technical expert
@ghost ghost added the area-Meta label Nov 7, 2022
@ghost ghost assigned agocke Nov 7, 2022
@ghost
Copy link

ghost commented Nov 7, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a new area-tools-linker and assign myself as the lead and @sbomer as technical expert

Author: agocke
Assignees: agocke
Labels:

area-Meta

Milestone: -

@agocke agocke requested a review from sbomer November 7, 2022 17:46
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if @vitek-karas wants to be added to the list.

@agocke
Copy link
Member Author

agocke commented Nov 8, 2022

Added Vitek as well

@danmoseley
Copy link
Member

You'll presumably want to label whatever you can (transferred issues and any PRs) and then ask Drew to retrain the labeler.

| area-System.Xml | @jeffhandley | @dotnet/area-system-xml | |
| area-Threading-mono | @SamMonoRT | @lambdageek | |
| area-TieredCompilation-coreclr | @mangod9 | @kouvel | |
| area-Tools-ILLink | @agocke | @sbomer | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you introduce @dotnet/area-illink alias, it would help to tag all interested folks ad hoc as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have @dotnet/linker-contrib. I just renamed it to @dotnet/illink-contrib.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffschwMSFT jeffschwMSFT merged commit 134948e into dotnet:main Nov 8, 2022
@agocke agocke deleted the add-linker-area branch November 8, 2022 22:39
@joperezr
Copy link
Member

joperezr commented Nov 9, 2022

@agocke did we validate that the change was valid in the fabricbot portal? I'm seeing that fabricbot automations are not running today, and when I try to load the current configuration in fabricbot for this repo it fails to parse and says that there are no bot configurations tasks for this repository.

@joperezr
Copy link
Member

joperezr commented Nov 9, 2022

"mentionees": [
"agocke",
"sbomer",
"vitek-karas",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this trailing comma is causing problems?

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants