Add HashTo/GetCurrentHashAs{UInt32/64} methods#78075
Add HashTo/GetCurrentHashAs{UInt32/64} methods#78075stephentoub merged 3 commits intodotnet:mainfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
@bartonjs, mind taking a look? Thanks. |
bartonjs
left a comment
There was a problem hiding this comment.
Code LGTM. Based on the conversation I had with @GrabYourPitchforks when the API was proposed, and our assertion of GetCurrentHashCode() being king, I'd expect the endianness comments in all of the integer-based values (as a remarks remark or just as part of the returns ("Returns the [whatever algorithm] hash code using little-endian byte ordering."), maybe with a <seealso cref="GetCurrentHash()" />.
|
Thanks for the review. |
|
Hi @stephentoub , the new test cases added here all fail on s390x, from the logs it looks like an obvious endian problem: etc. |
Fixes #76279