-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[NativeAOT] Address some COOP native helpers that could cause suspension pauses. #78450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes: #73655 Fixes common cases of unbounded data copying in COOP mode, that may cause suspension pauses. Also moves I think Mono may use it too and benefit form interruptibility, but I am not sure.
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks! |
|
@BrzVlad Re: |
Fixes: #73655
Fixes common cases of unbounded data copying in COOP mode, that may cause suspension pauses.
(Such pauses were actually observed while testing and measuring suspension changes)
Also moves
Buffer.Memmove<T>to shared code to be used by both CoreCLR and NativeAOT.I think Mono may use it too and benefit form interruptibility, in theory, but I am not sure.
For blobs containing GC references, we perform GC-atomic card-updating copies in chunks which are not necessarily aligned to array elements. I am not sure if Mono
BulkMoveWithWriteBarriercan be used like this.