Change MetricSpec.TryParse to be Parse #78729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was always creating a MetricSpec and returning true.
ghost
added
the
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsIt was always creating a MetricSpec and returning true. Fixes #78625
|
tarekgh
approved these changes
Nov 22, 2022
tarekgh
added
area-System.Diagnostics.Metric
and removed
area-System.Diagnostics.Tracing
labels
Member
|
CC @noahfalk |
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
…iagnostics/Metrics/MetricsEventSource.cs Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was always creating a MetricSpec and returning true.
Fixes #78625