You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another collection of changes that can be merged independently of actual test merging. It may be easier to look at each commit separately. I have them collected here in order to just do one PR process, but I can split them if needed. Automated changes were done with the ILTransform tool (started by @trylek, my version at https://github.com/markples/utils/tree/for-PR-dotnet-runtime-79697, commit 6324a32f).
Add <RequiresProcessIsolation>true</RequiresProcessIsolation> for any test with CLRTestTargetUnsupported, GCStressIncompatible, UnloadabilityIncompatible, JitOptimizationSensitive, TieringTestIncompatible, HeapVerifyIncompatible, IlasmRoundTripIncompatible, SynthesizedPgoIncompatible, or CrossGenTest properties.
Add <RequiresProcessIsolation>true</RequiresProcessIsolation> for any test with CLRTestBashEnvironmentVariable, CLRTestBatchEnvironmentVariable, CLRTestEnvironmentVariable, Content, CMakeProjectReference (not sure about the last two, but they only impact 3 tests and can be examined later)
Add <RequiresProcessIsolation>true</RequiresProcessIsolation> for any test that calls Environment.Exit
Add comment explaining why RequiresProcessIsolation is set to help with removing them later
"Build Installer Build and Test coreclr OSX_x64 Release" failure is a timeout. The entire leg ran incredibly slowly from the beginning (project restore, configuring), so I don't think it is relevant here.
Note: I force pushed back to an earlier version of this change without class deduplication. The tests pass with and without, but in doing the next steps I discovered that it appears that all classes, not just the entry point ones, need to be unique. Therefore, I will be reimplementing the dedup logic. The changes here can be merged without dedup - I had simply added those since they build on this PR and (I thought) were ready.
ghost
locked as resolved and limited conversation to collaborators
Jan 21, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMItest-enhancementImprovements of test source code
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
assigned
markples
added
test-enhancement
This is another collection of changes that can be merged independently of actual test merging. It may be easier to look at each commit separately. I have them collected here in order to just do one PR process, but I can split them if needed. Automated changes were done with the ILTransform tool (started by @trylek, my version at https://github.com/markples/utils/tree/for-PR-dotnet-runtime-79697, commit 6324a32f).
Remove test JIT/Regression/VS-ia64-JIT/V1.2-Beta1/b102887 - identical…
Dedup class names in GitHub_23199
Merge b399444 into one test that handles both cases
Add RequiresProcessIsolation
ILTransform -prociso<RequiresProcessIsolation>true</RequiresProcessIsolation>for any test with CLRTestTargetUnsupported, GCStressIncompatible, UnloadabilityIncompatible, JitOptimizationSensitive, TieringTestIncompatible, HeapVerifyIncompatible, IlasmRoundTripIncompatible, SynthesizedPgoIncompatible, or CrossGenTest properties.<RequiresProcessIsolation>true</RequiresProcessIsolation>for any test with CLRTestBashEnvironmentVariable, CLRTestBatchEnvironmentVariable, CLRTestEnvironmentVariable, Content, CMakeProjectReference (not sure about the last two, but they only impact 3 tests and can be examined later)<RequiresProcessIsolation>true</RequiresProcessIsolation>for any test that calls Environment.ExitILTransform -public
ILTransform -publicMainfor C#, whatever is marked.entrypointfor IL) to be publicManual fixes for public changes