Fix assembly unloading for DispatchInfo #80203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create DispatchInfo functions for manipulating loader handles instead of sharing the LoaderAllocator. Make the DispatchMemberInfo look more regular and make all fields private.
ghost
assigned
janvorli
approved these changes
Jan 5, 2023
Member
janvorli
left a comment
janvorli
left a comment
There was a problem hiding this comment.
LGTM modulo the nit, thank you for fixing it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
DispatchInfofunctions for manipulatingloader handles instead of exposing the
LoaderAllocator.Make the
DispatchMemberInfolook moreregular and make all fields private.
Fixes #79588