Skip to content

[wasm] Run library tests with v8 --experimental-wasm-eh #80271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radical wants to merge 3 commits into from
Closed

[wasm] Run library tests with v8 --experimental-wasm-eh #80271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9580e3b
[wasm] Run library tests with v8 --experimental-wasm-eh
radical Jan 5, 2023
97e8ad8
[wasm] Fix v8 arg
radical Jan 5, 2023
b3521a1
[wasm] Update path triggers to account for eng/testing/Wasm*
radical Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/pipelines/common/evaluate-default-paths.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ parameters:
_wasm_specific_only: [
eng/testing/ProvisioningVersions.props
eng/testing/scenarios/BuildWasmAppsJobsList.txt
eng/testing/Wasm*
eng/testing/tests.wasm.targets
src/libraries/sendtohelix-wasm.targets
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Sdk/*
Expand Down Expand Up @@ -56,6 +57,7 @@ jobs:
- eng/pipelines/installer/*
- eng/pipelines/mono/*
- eng/pipelines/libraries/*
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}

Expand Down Expand Up @@ -140,6 +142,7 @@ jobs:
- eng/pipelines/mono/*
- eng/pipelines/libraries/*
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._always_exclude }}

# We have limited Apple Silicon testing capacity
Expand Down
9 changes: 5 additions & 4 deletions eng/testing/WasmRunnerAOTTemplate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,22 @@ if [[ -z "$XHARNESS_COMMAND" ]]; then
fi

if [[ "$XHARNESS_COMMAND" == "test" ]]; then
if [[ -z "$JS_ENGINE_ARGS" ]]; then
JS_ENGINE_ARGS="--engine-arg=--stack-trace-limit=1000"
fi

if [[ -z "$JS_ENGINE" ]]; then
if [[ "$SCENARIO" == "WasmTestOnNodeJS" || "$SCENARIO" == "wasmtestonnodejs" ]]; then
JS_ENGINE="--engine=NodeJS"
else
JS_ENGINE="--engine=V8"
JS_ENGINE_ARGS="$JS_ENGINE_ARGS --engine-arg=--experimental-wasm-eh"
fi
fi

if [[ -z "$MAIN_JS" ]]; then
MAIN_JS="--js-file=test-main.js"
fi

if [[ -z "$JS_ENGINE_ARGS" ]]; then
JS_ENGINE_ARGS="--engine-arg=--stack-trace-limit=1000"
fi
fi

if [[ -z "$XHARNESS_ARGS" ]]; then
Expand Down
9 changes: 5 additions & 4 deletions eng/testing/WasmRunnerTemplate.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,21 @@ if [%XHARNESS_COMMAND%] == [] (
)

if /I [%XHARNESS_COMMAND%] == [test] (
if [%JS_ENGINE_ARGS%] == [] (
set "JS_ENGINE_ARGS=--engine-arg^=--stack-trace-limit^=1000"
)

if [%JS_ENGINE%] == [] (
if /I [%SCENARIO%] == [WasmTestOnNodeJS] (
set "JS_ENGINE=--engine^=NodeJS"
) else (
set "JS_ENGINE=--engine^=V8"
set "JS_ENGINE_ARGS=%JS_ENGINE_ARGS% --engine-arg^=--experimental-wasm-eh"
)
)
if [%MAIN_JS%] == [] (
set "MAIN_JS=--js-file^=test-main.js"
)

if [%JS_ENGINE_ARGS%] == [] (
set "JS_ENGINE_ARGS=--engine-arg^=--stack-trace-limit^=1000"
)
) else (
if [%BROWSER_PATH%] == [] if not [%HELIX_CORRELATION_PAYLOAD%] == [] (
set "BROWSER_PATH=--browser-path^=%HELIX_CORRELATION_PAYLOAD%\chrome-win\chrome.exe"
Expand Down