[QUIC] Log msquic version and commit hash to event log and to test output. #80612
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl |
| if (NetEventSource.Log.IsEnabled()) | ||
| { | ||
| NetEventSource.Info(null, $"Incompatible MsQuic library version '{version}', expecting '{MsQuicVersion}'"); | ||
| NetEventSource.Error(null, $"Cannot retrieve {nameof(QUIC_PARAM_GLOBAL_LIBRARY_GIT_HASH)} from MsQuic library: '{status}'."); |
There was a problem hiding this comment.
Did you check it with both official and manually build package?
There was a problem hiding this comment.
CI is running with the official packages and I run locally with manually built msquic from the its main branch.
There was a problem hiding this comment.
CI would not log events though, would it?
There was a problem hiding this comment.
Note that this won't get hit unless the library is built without this property, which doesn't exists ATM. It's just checking for the status as we do with all msquic calls.
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs
Outdated
Show resolved
Hide resolved
| uint paramSize; | ||
| int status; | ||
|
|
||
| arraySize = 4; |
There was a problem hiding this comment.
It'd be better if these could be consts, e.g.
https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AXEBDAzgWwB8ABAJgEYBYAKGIAYACY8gOgCUBXAOwwEt8YLAMIR8AB14AbGFADKMgG68wMXAG4aNANr4IAEw7SQDWQGteYgDIQw2SbgCSXXhgC6m2gGYmpBkIYA3jQMIUze3LjYAGYwDLjAAJ4YsQCy5AAUAJSBwaF5kFy4GAy8PAwAglBQ2AmyvABesQC8DCga1Hl58UkwAFQMYhhQDC1F2GCmdpI2cYnJWpXVtQ0wru2docQA7ANDWnRruSEAvkcMZ8ThhdGx3ckMKaRZOR0bJWWLNXWNI63rb3c+rthqMMONJpJpmBZj0FlUvitDq8NttgfskXlTtRjkA==
There was a problem hiding this comment.
How much does this matter if this is called once per the whole application? Or is this more about setting up good examples/usage patterns?
EDIT: I did change it in the code, I'm just curious about the reasoning.
5 participants
Fixes #75596