-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[Android] Bump target SDK version in Android manifest #80923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Bump target SDK version in Android manifest #80923
Conversation
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsWe should run our tests targeting API 31 which is currently the Google Play's requirement.
|
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
67a19ba to
cd8f5b9
Compare
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The test |
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The remaining failing tests on Android are related to #80909. |
|
/backport to release/7.0-staging |
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/7133508892 |
|
@fanyang-mono backporting to release/7.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Set target SDK version
Applying: Update Android docs
Applying: Disable tests that do not pass with target API 31
Applying: Check if the installed Android SDK is up-to-date
error: sha1 information is lacking or useless (src/tasks/AndroidAppBuilder/Templates/AndroidManifest.xml).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Check if the installed Android SDK is up-to-date
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@fanyang-mono an error occurred while backporting to release/7.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
We should run our tests targeting API 31 which is currently the Google Play's requirement.
It will be necessary to use Android SDK 31+ for local builds. The build process will show an error message instructing the developer to install newer build tools it they're out of date. The CI already uses SDK version 33 (dotnet/dotnet-buildtools-prereqs-docker#713).