Revert "Inline resource strings in the compiler (#80896)" #81455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 759fecb.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis reverts commit 759fecb. Reverting it to fix the fallout in extra-platforms for now: #81409 (comment) There are two problems that I can see:
|
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Feb 1, 2023
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Feb 1, 2023
Addresses first bullet of dotnet#81455. Addresses 211 test failures to the tune of: ``` [FAIL] System.Xml.XmlSchemaValidatorApiTests.TCValidateWhitespace_String.WhitespaceInsideElement System.Xml.Tests.VerifyException : GetManifestResourceStream() failed at System.Xml.Tests.ExceptionVerifier..ctor(String assemblyName, ExceptionVerificationFlags flags, ITestOutputHelper output) + 0x4c9 at System.Xml.XmlSchemaValidatorApiTests.TCValidateWhitespace_String..ctor(ITestOutputHelper output) + 0x48 ```
MichalStrehovsky
added
the
NO-MERGE
Member
Author
MichalStrehovsky
added a commit
that referenced
this pull request
Feb 1, 2023
Addresses first bullet of #81455. Addresses 211 test failures to the tune of: ``` [FAIL] System.Xml.XmlSchemaValidatorApiTests.TCValidateWhitespace_String.WhitespaceInsideElement System.Xml.Tests.VerifyException : GetManifestResourceStream() failed at System.Xml.Tests.ExceptionVerifier..ctor(String assemblyName, ExceptionVerificationFlags flags, ITestOutputHelper output) + 0x4c9 at System.Xml.XmlSchemaValidatorApiTests.TCValidateWhitespace_String..ctor(ITestOutputHelper output) + 0x48 ```
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 759fecb.
Reverting it to fix the fallout in extra-platforms for now: #81409 (comment)
There are two problems that I can see:
Type.GetType("System.SR, blah").GetMethod("GetResourceString");to the test - this will trick the compiler into thinking the optimization has been defeated).<UseSystemResourceKeys>true</UseSystemResourceKeys>specified. Will need to look into that more.