Skip to content

Fix pal tests build on osx-arm64 #81604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AaronRobinsonMSFT merged 1 commit into from
Feb 13, 2023
Merged

Fix pal tests build on osx-arm64 #81604

AaronRobinsonMSFT merged 1 commit into from
Feb 13, 2023

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 3, 2023

Switched to use snprintf based on:

nopal.cpp:20:21: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.
Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you
use snprintf(3) instead.

@ghost ghost added area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member labels Feb 3, 2023
@am11 am11 force-pushed the feature/pal-tests branch 2 times, most recently from eb65f33 to 0bd45c8 Compare February 3, 2023 22:19
@am11 am11 force-pushed the feature/pal-tests branch from 0bd45c8 to 4e9f9fd Compare February 3, 2023 22:45
@am11 am11 marked this pull request as ready for review February 3, 2023 22:45
@am11 am11 requested a review from janvorli February 3, 2023 22:45
@build-analysis build-analysis bot mentioned this pull request Feb 4, 2023
Closed
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 6e68f56 into dotnet:main Feb 13, 2023
@am11 am11 deleted the feature/pal-tests branch February 13, 2023 17:38
@jakobbotsch jakobbotsch mentioned this pull request Feb 13, 2023
Closed
AaronRobinsonMSFT added a commit that referenced this pull request Feb 13, 2023
@AaronRobinsonMSFT
Revert "Fix pal tests build on osx-arm64 (#81604)"
a7fc47f 
This reverts commit 6e68f56.
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Feb 13, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@janvorli janvorli Awaiting requested review from janvorli

Assignees

No one assigned

Labels

area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@am11 @AaronRobinsonMSFT