Fix src/tests/build.sh argument processing #81836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #81439 I added logic to src/tests/build.sh that would support the same syntax as the cmd script for the test filter args. However, this isn't working correctly because the
shifthappens inside a sourced script, and doesn't actually shift the outer arguments. The right way to do this is via__ShiftArgs.Without this fix,
tree nativeaotwas working becausenativeaothappened to be a supported argument as well. With the fix, other test subtrees work as expected.