Skip to content

Cache copies of register sets and data that varies with AVX512 #81868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BruceForstall merged 2 commits into from
Feb 9, 2023
Merged

Cache copies of register sets and data that varies with AVX512 #81868

BruceForstall merged 2 commits into from
Feb 9, 2023

Conversation

@BruceForstall
Copy link
Contributor

@BruceForstall BruceForstall commented Feb 9, 2023

  1. Fix availableRegCount to only be stored in LSRA, where it is used.
  2. Make copies of rbmAllFloat/rbmFltCalleeTrash to CodeGen and LSRA classes during construction, so access is "closer", in case TP is impacted. (This also makes it possible to define inline accessors in the emitter class.)

@BruceForstall
Cache copies of register sets and data that varies with AVX512
3c15ce3 
1. Fix availableRegCount to only be stored in LSRA, where it is used.
2. Make copies of rbmAllFloat/rbmFltCalleeTrash to CodeGen and LSRA
classes during construction, so access is "closer", in case TP is
impacted. (This also makes it possible to define inline accessors in
the `emitter` class.)
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 9, 2023
@ghost ghost assigned BruceForstall Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Fix availableRegCount to only be stored in LSRA, where it is used.
  2. Make copies of rbmAllFloat/rbmFltCalleeTrash to CodeGen and LSRA classes during construction, so access is "closer", in case TP is impacted. (This also makes it possible to define inline accessors in the emitter class.)
Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak
Copy link
Contributor

kunalspathak commented Feb 9, 2023

Related #81847

tannergooding
tannergooding approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small wins back from the initial TP regression!

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Feb 9, 2023

No diffs (as expected)

Small TP improvements:

linux x64
Overall (-0.07% to -0.04%)
MinOpts (-0.09% to -0.02%)
FullOpts (-0.07% to -0.04%)

windows x64
Overall (-0.07% to -0.03%)
MinOpts (-0.09% to -0.02%)
FullOpts (-0.07% to -0.04%)

@BruceForstall BruceForstall marked this pull request as ready for review February 9, 2023 16:54
@BruceForstall
Copy link
Contributor Author

BruceForstall commented Feb 9, 2023

cc @kunalspathak @anthonycanino @dotnet/jit-contrib

@anthonycanino
Copy link
Contributor

anthonycanino commented Feb 9, 2023

Changes look good to me. Do we know the absolute tp diff now?

kunalspathak
kunalspathak approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice TP win!

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Feb 9, 2023

Changes look good to me. Do we know the absolute tp diff now?

Compared to pre #79544? No, and the improvement is still small compared to that regression.

@BruceForstall BruceForstall merged commit db00f4e into dotnet:main Feb 9, 2023
@BruceForstall BruceForstall deleted the CopyAvx512RegData branch February 9, 2023 18:43
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding approved these changes

+1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstall BruceForstall

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall @kunalspathak @anthonycanino @tannergooding