Tweak coreclr test build script #81975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. No longer use `-priority=1` syntax: use `-priority 1` instead. It was already documented this way, and probably works both ways on Windows because batch scripts "eat" the `=` sign sometimes. 2. Fix a YML script to not pass the `=`. This is probably unused code currently because we build tests in CoreCLR on Linux. 3. Add a few more `%MsgPrefix%` output lines.
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue Details
|
Contributor
Author
|
Kind of a follow-up to #81733 |
trylek
approved these changes
Feb 10, 2023
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
LGTM, thanks Bruce for further cleaning up our various scripts right after Jeff's change, it's been a while since I last saw this rate of infra improvements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-priority=1syntax: use-priority 1instead. It was already documented this way, and probably works both ways on Windows because batch scripts "eat" the=sign sometimes.=. This is probably unused code currently because we build tests in CoreCLR on Linux.%MsgPrefix%output lines.