Skip to content

Console.Tests: extend VerifyInstalledTermInfosParse test. #82025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 1 commit into from
Feb 13, 2023
Merged

Console.Tests: extend VerifyInstalledTermInfosParse test. #82025

adamsitnik merged 1 commit into from
Feb 13, 2023

Conversation

@tmds
Copy link
Member

@tmds tmds commented Feb 13, 2023

  • Run against TERMINFO envvar, and HOME terminfo too.
  • Don't stop on first problem, aggregate exceptions.
  • Include database file name in the exception.

@adamsitnik ptal.

@tmds
Console.Tests: extend VerifyInstalledTermInfosParse test.
e58ae4e 
- Run against TERMINFO envvar, and HOME terminfo too.
- Don't stop on first problem, aggregate exceptions.
- Include database file name in the exception.
@ghost ghost added area-System.Console community-contribution Indicates that the PR has been added by a community member labels Feb 13, 2023
@ghost
Copy link

ghost commented Feb 13, 2023

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Run against TERMINFO envvar, and HOME terminfo too.
  • Don't stop on first problem, aggregate exceptions.
  • Include database file name in the exception.

@adamsitnik ptal.

Author: tmds
Assignees: -
Labels:

area-System.Console, community-contribution
Milestone: -

@tmds tmds mentioned this pull request Feb 13, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Feb 13, 2023
Closed
adamsitnik
adamsitnik approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tmds !

@adamsitnik adamsitnik merged commit ae6666d into dotnet:main Feb 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

No one assigned

Labels

area-System.Console community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmds @adamsitnik