Skip to content

[wasm] Debugger tests - fix build #82958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radical merged 2 commits into from
Mar 3, 2023
Merged

[wasm] Debugger tests - fix build #82958

radical merged 2 commits into from
Mar 3, 2023

Conversation

@radical
Copy link
Member

@radical radical commented Mar 3, 2023 •
edited
Loading

/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment

Started being hit with #82479 .
The other instances of this were fixed in #82803 .

  • Also, adds a change so all the wasm jobs would get triggered whenever Roslyn is updated.

Fixes #82962 .

radical added 2 commits March 3, 2023 21:43
@radical
[wasm] Debugger tests - fix build
0f59eb1 
`/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment`

Started being hit with dotnet#82479 .
The other instances of this were fixed in
dotnet#82803 .
@radical
CI: Trigger all the wasm jobs, when roslyn is updated
dc77fb2 
And this includes the debugger tests
@radical radical added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Build-mono labels Mar 3, 2023
@radical radical requested review from lewing and pavelsavara March 3, 2023 21:51
@radical radical requested a review from thaystg as a code owner March 3, 2023 21:51
@ghost ghost assigned radical Mar 3, 2023
@ghost
Copy link

ghost commented Mar 3, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment

Started being hit with #82479 .
The other instances of this were fixed in #82803 .

  • Also, adds a change so all the wasm jobs would get triggered whenever Roslyn is updated.
Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, area-Build-mono
Milestone: -

@lewing
Copy link
Member

lewing commented Mar 3, 2023

if this is breaking CI you can merge it before tests complete

@radical
Copy link
Member Author

radical commented Mar 3, 2023

The debugger tests built without issues. Merging this to unbreak CI.

@radical radical merged commit f46caec into dotnet:main Mar 3, 2023
@radical radical deleted the wasm-fix-build branch March 3, 2023 22:28
@build-analysis build-analysis bot mentioned this pull request Mar 4, 2023
Closed
@lewing lewing mentioned this pull request Mar 6, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@thaystg thaystg thaystg approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] Debugger tests build broken on main

3 participants

@radical @lewing @thaystg