Skip to content

Conversation

@antonfirsov
Copy link
Contributor

@antonfirsov antonfirsov commented Mar 9, 2023

Tried using another Windows image, which did not work (#82736), so decided to go with the workaround from actions/runner-images#7080 (comment) to fix #82528.

@ghost
Copy link

ghost commented Mar 9, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Attempt to fix #82528, using a workaround from actions/runner-images#7080 (comment).

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov antonfirsov marked this pull request as draft March 9, 2023 16:09
@ghost ghost assigned antonfirsov Mar 9, 2023
@azure-pipelines

This comment was marked as resolved.

@antonfirsov antonfirsov marked this pull request as ready for review March 9, 2023 19:08
@azure-pipelines

This comment was marked as resolved.

1 similar comment
@azure-pipelines

This comment was marked as resolved.

@antonfirsov antonfirsov requested a review from a team March 9, 2023 19:09
@azure-pipelines

This comment was marked as resolved.

1 similar comment
@azure-pipelines

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@antonfirsov antonfirsov marked this pull request as draft March 10, 2023 16:28
@antonfirsov
Copy link
Contributor Author

/azp run runtime-libraries stress-ssl

@antonfirsov
Copy link
Contributor Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor Author

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/ncl this seems to work, can someone take a look?

Comment on lines +20 to +23
$dockerComposeCmd = $env:DOCKER_COMPOSE_CMD
if (!(Test-Path $dockerComposeCmd)) {
$dockerComposeCmd = "docker-compose"
}
Copy link
Contributor Author

@antonfirsov antonfirsov Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now an asymmetry between run-docker-compose.ps1 in SslStress vs HttpStress.
For some reason, the HttpStress pipeline is ok to docker-compose build with V1 of compose but then do the run with V2, however in SslStress this resulted in a failure.
I don't want to add an equivalent workaround to run-docker-compose.ps1 in HttpStress, when it's not necessary.

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov antonfirsov marked this pull request as ready for review March 14, 2023 14:25
@antonfirsov antonfirsov merged commit d6b89c6 into dotnet:main Mar 14, 2023
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpStress execution failure on Windows

3 participants