You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were testing using --depsfile to point at a .deps.json in a different location. They would built/run an actual app with a dependency on Newtonsoft.Json and check that dependency could/could not be found. We really just care how a dependency is resolved based on the passed deps.json, so the tests can be switched to use our mock coreclr (and avoid issues like we hit in #82599 (comment))
This removes one of the pieces we have that had the host test assets using Newtonsoft.Json. I think the remaining ones are the --additionalprobingpath tests (should be moveable to mock coreclr) and startup hook tests (can use a different dependency or be moved to runtime tests).
These were testing using --depsfile to point at a .deps.json in a different location. They would built/run an actual app with a dependency on Newtonsoft.Json and check that dependency could/could not be found. We really just care how a dependency is resolved based on the passed deps.json, so the tests can be switched to use our mock coreclr.
This removes one of the pieces we have that had the host test assets using Newtonsoft.Json. I think the remaining ones are the --additionalprobingpath tests (should be moveable to mock coreclr) and startup hook tests (can use a different dependency or be moved to runtime tests).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
assigned
These were testing using
--depsfileto point at a .deps.json in a different location. They would built/run an actual app with a dependency on Newtonsoft.Json and check that dependency could/could not be found. We really just care how a dependency is resolved based on the passed deps.json, so the tests can be switched to use our mock coreclr (and avoid issues like we hit in #82599 (comment))This removes one of the pieces we have that had the host test assets using Newtonsoft.Json. I think the remaining ones are the
--additionalprobingpathtests (should be moveable to mock coreclr) and startup hook tests (can use a different dependency or be moved to runtime tests).