Skip to content

Handle recursive type graphs in config binding generator #83644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
layomia merged 1 commit into from
Mar 20, 2023
Merged

Handle recursive type graphs in config binding generator #83644

layomia merged 1 commit into from
Mar 20, 2023

Conversation

@layomia
Copy link
Contributor

@layomia layomia commented Mar 19, 2023 •
edited
Loading

Fixes #83539.

@layomia layomia added this to the 8.0.0 milestone Mar 19, 2023
@layomia layomia self-assigned this Mar 19, 2023
@ghost
Copy link

ghost commented Mar 19, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83539.
Second commit is the actual change. First commit is from #83614 which needs to be merged first.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration
Milestone: 8.0.0

@layomia layomia force-pushed the binder-gen-recursive-types branch 2 times, most recently from e0fb5ef to 87f9a5b Compare March 20, 2023 18:57
@layomia layomia force-pushed the binder-gen-recursive-types branch from 87f9a5b to 4400a5b Compare March 20, 2023 19:31
@layomia layomia marked this pull request as ready for review March 20, 2023 19:33
This was referenced Mar 20, 2023
Closed
Closed
@carlossanlop
Copy link
Contributor

carlossanlop commented Mar 20, 2023

@layomia CI is done. How's this looking? Is it good to merge?

@layomia
Copy link
Contributor Author

layomia commented Mar 20, 2023

@layomia CI is done. How's this looking? Is it good to merge?

Looking good thanks.

@layomia layomia merged commit 4bd7819 into dotnet:main Mar 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
@layomia layomia added the source-generator Indicates an issue with a source generator feature label May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj left review comments

@tarekgh tarekgh tarekgh approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@krwq krwq Awaiting requested review from krwq

Assignees

@layomia layomia

Labels

area-Extensions-Configuration source-generator Indicates an issue with a source generator feature

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Handle recursive type graphs in config binding generator

4 participants

@layomia @carlossanlop @ericstj @tarekgh