[release/8.0-preview3] [mono][jit] Increased max length of OP_STOREX_MEMBASE to 16 on arm64. #83887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
lambdageek
approved these changes
Mar 24, 2023
vargaz
approved these changes
Mar 24, 2023
Member
|
cc @carlossanlop we'd like to get this one in too, if there's still time. |
Contributor
|
@mmitche do we have runway? This one's important. |
Member
|
Yes. |
Contributor
|
CI failures are unrelated. |
This was referenced Mar 24, 2023
Member
|
/cc @carlossanlop @mmitche - CI failures are unrelated. This is ready to be merged pending Tactics approval. |
Contributor
|
Approved by Tactics via email. |
carlossanlop
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #83770 to release/8.0-preview3
/cc @jandupej
Customer Impact
Crashes can occur on arm64 platforms (JIT) when SIMD is used through
Vector128operators. This resolves the crashes by fixing the expected maximum codegen length forOP_STOREX_MEMBASE.Testing
The failures manifest in CI on arm64 platforms in
System.Numerics.Vectors.Tests. Assertions likewrong maximal instruction length of instruction storex_membase (expected 12, got 16) Assertion: should not be reached at /__w/1/s/src/mono/mono/mini/mini-arm64.c:5066are generated. The fix removes those failures.Risk
Low.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.