Skip to content

[wasm] Fix publishing Microsoft.NET.Sdk.WebAssembly.Pack #84754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maraf wants to merge 1 commit into from
Closed

[wasm] Fix publishing Microsoft.NET.Sdk.WebAssembly.Pack #84754

maraf wants to merge 1 commit into from

Conversation

@maraf
Copy link
Member

@maraf maraf commented Apr 13, 2023

Update pattern for matching RidAgnosticNupkgToPublishFile to include Microsoft.NET.Sdk.WebAssembly.Pack.

Fixes #84742

@maraf maraf added arch-wasm WebAssembly architecture packaging Related to packaging labels Apr 13, 2023
@maraf maraf added this to the 8.0.0 milestone Apr 13, 2023
@maraf maraf self-assigned this Apr 13, 2023
@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Update pattern for matching RidAgnosticNupkgToPublishFile to include Microsoft.NET.Sdk.WebAssembly.Pack.

Fixes #84742

Author: maraf
Assignees: maraf
Labels:

arch-wasm, packaging
Milestone: 8.0.0

@maraf maraf mentioned this pull request Apr 13, 2023
Closed
@maraf maraf requested review from ViktorHofer, lewing and sbomer April 13, 2023 07:45
@maraf maraf mentioned this pull request Apr 13, 2023
Merged
@maraf
Copy link
Member Author

maraf commented Apr 13, 2023

The official build shows that the Microsoft.NET.Sdk.WebAssembly.Pack is part of the ItemsToPush that are passed to the PushToAzureDevOpsArtifacts

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 13, 2023

You also need to revert the revert commit: d0a287a

@maraf
Copy link
Member Author

maraf commented Apr 13, 2023 •
edited
Loading

Closed in favor of #84761

@maraf maraf closed this Apr 13, 2023
@maraf maraf deleted the WasmFixOfficialBuild branch April 13, 2023 15:31
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomer sbomer Awaiting requested review from sbomer

@lewing lewing Awaiting requested review from lewing

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Infrastructure-installer packaging Related to packaging

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Official build failure trying to sign Microsoft.NET.Sdk.WebAssembly.Pack

2 participants

@maraf @ViktorHofer