Skip to content

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 17, 2023

The STORE counterpart to #84221.

No diffs, a small TP improvement on 32 bit.

Note: diff best viewed with the "hide whitespaces" option.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 17, 2023
@SingleAccretion SingleAccretion marked this pull request as ready for review April 18, 2023 07:43
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jakobbotsch jakobbotsch merged commit 7b662a7 into dotnet:main Apr 19, 2023
@SingleAccretion SingleAccretion deleted the Delete-StoreObj branch April 19, 2023 20:25
Comment on lines +7305 to +7308
BlkOpKindCpObjUnroll,
#ifdef TARGET_XARCH
BlkOpKindCpObjRepInstr,
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are missing handling in gtDispTree, can you submit a fix? (They currently hit an unreached())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it.

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants