Skip to content

Add a test for STORE_DYN_BLK(..., IND(null), ...) #85103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 1 commit into from
Apr 23, 2023
Merged

Add a test for STORE_DYN_BLK(..., IND(null), ...) #85103

jakobbotsch merged 1 commit into from
Apr 23, 2023

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 20, 2023

The underlying problem was fixed by marking the source indirection with NO_CSE in #83814.

Closes #62328.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

The underlying problem was fixed by marking the source indirection with NO_CSE in #83814.

Closes #62328.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Apr 20, 2023
Closed
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Apr 20, 2023 •
edited
Loading

browser-wasm linux Release AllSubsets_Mono_RuntimeTests monointerpreter failure is #80619.

Just adding test for a fixed issue.

@dotnet/jit-contrib

@jakobbotsch
Copy link
Member

jakobbotsch commented Apr 21, 2023

Looks like license/cla is stuck, need to bounce it.

@jakobbotsch jakobbotsch reopened this Apr 21, 2023
@jakobbotsch jakobbotsch merged commit e8c4971 into dotnet:main Apr 23, 2023
@SingleAccretion SingleAccretion deleted the DynBlk-Assertions-Test branch May 1, 2023 15:12
@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dynamic block nodes should not generate non-null assertions

2 participants

@SingleAccretion @jakobbotsch