Fix superpmi.py to not cache local MCH files #85187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an MCH file is specified via the `-mch_file` argument, if that file is local (not on a UNC Windows share, on Windows), then don't copy it to the MCH file cache. This behavior -- to avoid caching local files -- was altered with dotnet#56871, but it's not clear from that PR if it was required for something or was something used for testing that wasn't reverted before merge. I'm guessing the latter since the code was simply commented out.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWhen an MCH file is specified via the This behavior -- to avoid caching local files -- was altered with #56871, but it's not clear from that PR if it was required for something or was something used for testing that wasn't reverted before merge. I'm guessing the latter since the code was simply commented out.
|
Contributor
Author
|
@kunalspathak PTAL |
Contributor
Yes, I don't remember too and may be it could be for some testing. |
kunalspathak
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an MCH file is specified via the
-mch_fileargument, if that file is local (not on a UNC Windows share, on Windows), then don't copy it to the MCH file cache.This behavior -- to avoid caching local files -- was altered with #56871, but it's not clear from that PR if it was required for something or was something used for testing that wasn't reverted before merge. I'm guessing the latter since the code was simply commented out.