Fix volatility checks in VN and loop side effects code #85467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIt is the LHS that carries A small number of regressions is expected.
|
Volatile stores should be processed at the point of ASG.
SingleAccretion
changed the title
This was referenced Apr 28, 2023
Contributor
Author
jakobbotsch
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the LHS that carries
GTF_IND_VOLATILE, notASGitself.Conversely, we should not invoke
fgMutateGcHeapwhen processing the LHS by itself.A small number of regressions (in the sense that we do not hoist/CSE some things) is expected.
Diffs.