Fix trimmability issues in Quic test #85579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
added
area-System.Net.Quic
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe NativeAOT runs of this test are broken. Trimming doesn't analyze the pattern that is here and this crashes with a NullRef. When doing reflection like this, one can temporarily add Cc @dotnet/ilc-contrib
|
This was referenced May 1, 2023
Contributor
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 1, 2023
wfurt
approved these changes
May 1, 2023
Member
|
Opened #85600 on the OSX native AOT failure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NativeAOT runs of this test are broken. Trimming doesn't analyze the pattern that is here and this crashes with a NullRef.
When doing reflection like this, one can temporarily add
<EnableTrimAnalyzer>true</EnableTrimAnalyzer>to the test project - it's going to flag anything that would put NativeAOT on the floor.Cc @dotnet/ilc-contrib