Skip to content

Conversation

@omajid
Copy link
Member

@omajid omajid commented May 2, 2023

Building this file on Fedora 38 (with clang 16, libstdc++ 13.1) fails with an error:

    runtime/src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp:216:49: error: expected ';' after expression
			    throw std::runtime_error{ "Peg failure" };
						    ^
						    ;

    runtime/src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp:216:36: error: no member named 'runtime_error' in namespace 'std'
			    throw std::runtime_error{ "Peg failure" };
				  ~~~~~^

    runtime/src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp:216:64: error: expected ';' after expression
			    throw std::runtime_error{ "Peg failure" };
								   ^
								   ;
    3 errors generated.

The class is defined in <stdexcept>, so import that too.

Building this file on Fedora 38 (with clang 16, libstdc++ 13.1) fails
with an error:

    runtime/src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp:216:49: error: expected ';' after expression
			    throw std::runtime_error{ "Peg failure" };
						    ^
						    ;

    runtime/src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp:216:36: error: no member named 'runtime_error' in namespace 'std'
			    throw std::runtime_error{ "Peg failure" };
				  ~~~~~^

    runtime/src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp:216:64: error: expected ';' after expression
			    throw std::runtime_error{ "Peg failure" };
								   ^
								   ;
    3 errors generated.

The class is defined in <stdexcept>, so import that too.
@ghost ghost added area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member labels May 2, 2023
@jkoritzinsky
Copy link
Member

Failures are unrelated.

@jkoritzinsky jkoritzinsky merged commit f510c5a into dotnet:main May 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants