Skip to content

Add tests for RUC warnings on override methods #86015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitek-karas merged 4 commits into from
May 12, 2023
Merged

Add tests for RUC warnings on override methods #86015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f87ff82
First
vitek-karas May 9, 2023
405e11b
Add issue links
vitek-karas May 9, 2023
fddd7bf
Add a test for https://github.com/dotnet/runtime/issues/86032
vitek-karas May 10, 2023
37641e2
Fix a test failure
vitek-karas May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions src/tools/illink/test/Mono.Linker.Tests.Cases/RequiresCapability/RequiresAccessedThrough.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public static void Main ()
{
TestRequiresOnlyThroughReflection ();
AccessedThroughReflectionOnGenericType<TestType>.Test ();
AccessedThroughGenericParameterAnnotation.Test ();
AccessThroughSpecialAttribute.Test ();
AccessThroughPInvoke.Test ();
AccessThroughNewConstraint.Test<TestType> ();
Expand Down Expand Up @@ -73,6 +74,59 @@ public static void Test ()
}
}

class AccessedThroughGenericParameterAnnotation
{
class TypeWithRequiresMethod
{
[RequiresUnreferencedCode("--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--")]
[RequiresDynamicCode ("--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--")]
[RequiresAssemblyFiles ("--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--")]
public static void MethodWhichRequires () { }
}

class TypeWithPublicMethods<[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] T>
{
public TypeWithPublicMethods () { }
}

[ExpectedWarning ("IL2026", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--")]
[ExpectedWarning ("IL3002", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.NativeAot)]
[ExpectedWarning ("IL3050", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.NativeAot)]
static void TestAccessOnGenericType ()
{
new TypeWithPublicMethods<TypeWithRequiresMethod> ();
}

static void MethodWithPublicMethods<[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] T> () { }

[ExpectedWarning ("IL2026", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--")]
[ExpectedWarning ("IL3002", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.NativeAot)]
[ExpectedWarning ("IL3050", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.NativeAot)]
static void TestAccessOnGenericMethod ()
{
MethodWithPublicMethods<TypeWithRequiresMethod> ();
}

static void MethodWithPublicMethodsInference<[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] T> (T instance) { }

// https://github.com/dotnet/runtime/issues/86032
// IL2026 should be produced by the analyzer as well, but it has a bug around inferred generic arguments
[ExpectedWarning ("IL2026", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.Trimmer | Tool.NativeAot)]
[ExpectedWarning ("IL3002", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.NativeAot)]
[ExpectedWarning ("IL3050", "--AccessedThroughGenericParameterAnnotation.TypeWithRequiresMethod.MethodWhichRequires--", ProducedBy = Tool.NativeAot)]
static void TestAccessOnGenericMethodWithInferenceOnMethod ()
{
MethodWithPublicMethodsInference (new TypeWithRequiresMethod ());
}

public static void Test ()
{
TestAccessOnGenericType ();
TestAccessOnGenericMethod ();
TestAccessOnGenericMethodWithInferenceOnMethod ();
}
}

class AccessThroughSpecialAttribute
{
// https://github.com/dotnet/linker/issues/1873
Expand Down
Loading