LSRA Throughput: Do not pass RegisterType for non-arm
#86016
Closed
+90
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced May 9, 2023
Contributor
Author
|
This itself doesn't seem to have any TP impact. Not taking makes the code cleaner because we won't see bunch of |
Contributor
|
I generally like code to be explicit about platform-specific behavior/arguments, but it's certainly cleaner without all the |
Contributor
Author
|
I will probably leave it as it is then. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a dedicated PR for a change in #85842 about wrapping
RegisterTypeparameter withARM_ARG(). Also added a comment that I missed in #85956.