[wasm] Disable the PackedSimd.Shuffle intrinsic. #86025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM crashes if the underlying intrinsic has a non-constant shuffle argument, and we can't guarantee that.
ghost
added
the
Contributor
Author
|
Maybe the c# definition should be removed too until this is resolved somehow. |
Contributor
Author
|
Another solution would be to make the indexes scalar arguments, and mark them with ConstantExpected. |
radekdoulik
approved these changes
Jun 7, 2023
This was referenced Jun 7, 2023
Member
|
remaining failures are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM crashes if the underlying intrinsic has a non-constant shuffle argument, and we can't guarantee that.