Fix official build of cross DAC components#86138
Merged
jkotas merged 9 commits intodotnet:mainfrom May 12, 2023
Merged
Conversation
Revert changes that broke build of the cross DAC linux-arm components Fixes dotnet#86073
|
Tagging subscribers to this area: @hoyosjs Issue DetailsRevert changes that broke build of the cross DAC linux-arm components Fixes #86073
|
jkotas
commented
May 12, 2023
| - script: $(Build.SourcesDirectory)/src/coreclr/build-runtime$(scriptExt) $(buildConfig) $(archType) -hostarch x64 $(osArg) -ci $(compilerArg) -component crosscomponents -cmakeargs "-DCLR_CROSS_COMPONENTS_BUILD=1" $(officialBuildIdArg) $(clrRuntimePortableBuildArg) | ||
| displayName: Build CoreCLR Cross-Arch Tools (Tools that run on x64 targeting x86) | ||
|
|
||
| - ${{ if and(eq(parameters.osGroup, 'windows'), eq(parameters.archType, 'x86')) }}: |
Member
Author
There was a problem hiding this comment.
This is reverting https://github.com/dotnet/runtime/pull/85947/files#diff-0605564a3ca1b4b1eca0cc0450b7628c0d027841259052a35825bd2e035484dfL205-L207 with a slight modification: We used to build the linux-arm targeting DAC in Windows arm build that is gone. We build it in Windows x86 build now.
hoyosjs
requested changes
May 12, 2023
jkotas
commented
May 12, 2023
|
|
||
| set __TargetArchX64=0 | ||
| set __TargetArchX86=0 | ||
| set __TargetArchArm=0 |
Member
Author
There was a problem hiding this comment.
Arm argument is necessary to specify linux-arm.
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
jkotas
commented
May 12, 2023
hoyosjs
reviewed
May 12, 2023
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
hoyosjs
approved these changes
May 12, 2023
Member
|
Simultaneous validation: https://dnceng.visualstudio.com/internal/_build/results?buildId=2179077 |
hoyosjs
reviewed
May 12, 2023
jkotas
commented
May 12, 2023
jkotas
commented
May 12, 2023
Contributor
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert changes that broke build of the cross DAC linux-arm components
Fixes #86073