add pre-built detection

[oleksandr-didyk]

Resolves #81468

Existing issues:

• Microsoft.CodeAnalysis 4.5.0 - add microsoft.codeanalysis 4.5.0 source-build-reference-packages#669
• DotNet.Build.Tasks issue - add pre-built detection #86151 (comment), solved by remove nuget 6.2.2 source-build-reference-packages#673
• runtime/src/libraries/pretest.proj - source-build logic has a check for test projects & the check complains about src/libraries/pretest.proj. Silenced it for the repo as requested in add pre-built detection #86151 (comment). Additionally, created Remove IsTestUsageByHeuristic logic in Source Build source-build#3453 to get rid of the check completely

CC: @MichaelSimons @ViktorHofer

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	oleksandr-didyk
Assignees:	oleksandr-didyk
Labels:	area-Infrastructure-libraries
Milestone:	-

[ViktorHofer]

starting from Arcade version 8.0.0-beta.23260.3 DotNet.Build.Tasks.TargetFrameworks.targets tries to load Nuget.Frameworks from SBRP during the build and fails

We have been relying on NuGet APIs underneath the Microsoft.DotNet.Build.Tasks.TargetFramework package for years. What's the reason for this showing up now?

[oleksandr-didyk]

starting from Arcade version 8.0.0-beta.23260.3 DotNet.Build.Tasks.TargetFrameworks.targets tries to load Nuget.Frameworks from SBRP during the build and fails

We have been relying on NuGet APIs underneath the Microsoft.DotNet.Build.Tasks.TargetFramework package for years. What's the reason for this showing up now?

I added SRBP for Nuget as part of this work, which was fine at first, but after my change in Arcade the build started failing as it was loading the ref pack in

[ViktorHofer]

source-build logic has a check for test projects & the check complains about src/libraries/pretest.proj. I can find a way to silence the check for this particular case. That, or maybe the proj should not have test in its name in the first place?

Yes, please silence the check. I'm not exactly happy about that validation tbh. We have other shipping projects with "Tests" in its name which currently are excluded from source build as they rely on external prebuilds, i.e. Microsoft.Extensions.DependencyInjection.Specifications.Tests. While those currently don't cause a problem, we might have other such cases in the future which we want to include during source build.

[oleksandr-didyk]

DotNet.Build.Tasks issue - starting from Arcade version 8.0.0-beta.23260.3 DotNet.Build.Tasks.TargetFrameworks.targets tries to load Nuget.Frameworks from SBRP during the build and fails (source); the version where this manifests has only one change, which is bump of DependencyModel to latest, i.e. I probably missed something during testing. Will investigate.

I think I figured out what happened, but will talk it out with Michael to be sure -> DotNet.Build.Tasks.TargetFrameworks package comes with a version of Nuget already inside of it, in the tools directory. This version is the one that gets loaded in.

In this case, it seems that during Arcade build the SBRP version of Nuget got included in the tools directory and crashes the build. I verified this building the latest Arcade version without SBRP and then using that version in runtime

[oleksandr-didyk]

@mmitche I followed your reasoning for baselining Analyzers in roslyn here as well, since it follows the same pattern of product build utilizing latest version while for repo build we cannot use intermediates (for now) or SBRP. Pinging just to verify if you think this train of thought is correct here as well. Thanks!

[lewing]

in the future please make sure to update the shas too when updating VersionDetails.xml

[oleksandr-didyk]

in the future please make sure to update the shas too when updating VersionDetails.xml

My bad, normally I update dependencies via the darc client, which handles this for me, but this time I did it manually. Will make sure to not forget this in the future