Skip to content

Conversation

@BruceForstall
Copy link
Contributor

Use the default, which is $(BUILD_SOURCESDIRECTORY)\artifacts\helixresults

Fixes #75169

Use the default, which is `$(BUILD_SOURCESDIRECTORY)\artifacts\helixresults`

Fixes dotnet#75169
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 17, 2023
@ghost ghost assigned BruceForstall May 17, 2023
@ghost
Copy link

ghost commented May 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Use the default, which is $(BUILD_SOURCESDIRECTORY)\artifacts\helixresults

Fixes #75169

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Contributor

I am wondering what fixed this in arcade?

@BruceForstall
Copy link
Contributor Author

I am wondering what fixed this in arcade?

This fix makes it possible: dotnet/arcade#10630. Without that fix, if you didn't set HelixResultsDestinationDir you'd get a syntax error (I think).

@BruceForstall BruceForstall merged commit 1ff48ad into dotnet:main Jun 15, 2023
@BruceForstall BruceForstall deleted the Fix75169 branch June 15, 2023 15:34
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Arcade HelixResultsDestinationDir workaround

2 participants