Use fully qualified type names for parameters and don't copy parameter attributes #86922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsBackport of #86899 to main Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
This was referenced May 31, 2023
hoyosjs
changed the title
Member
|
This is just a test port and has no product changes. I'm closing this for now. @hoyosjs Please let us know if this is needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3483 by not copying the attributes for the parameters on generated base implementation methods since they're not strictly necessary.
Backport of #86899 to main
/cc @jkoritzinsky @jtschuster