Skip to content

System.Data: override System.Data.Sql tfm only when ArcadeBuildFromSource.#86962

Merged
ViktorHofer merged 1 commit intodotnet:mainfrom
tmds:sql_tfm
May 31, 2023
Merged

System.Data: override System.Data.Sql tfm only when ArcadeBuildFromSource.#86962
ViktorHofer merged 1 commit intodotnet:mainfrom
tmds:sql_tfm

Conversation

@tmds
Copy link
Member

@tmds tmds commented May 31, 2023

@ghost ghost added area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member labels May 31, 2023
@ghost
Copy link

ghost commented May 31, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86946

@MichaelSimons @ViktorHofer ptal.

Author: tmds
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with that change but as @MichaelSimons mentioned, using sourcebuild without using arcade powered source build is a non tested and unsupported scenario. I would recommend to switch to the ARPOW model.

@tmds
Copy link
Member Author

tmds commented May 31, 2023

I'm OK with that change but as @MichaelSimons mentioned, using sourcebuild without using arcade powered source build is a non tested and unsupported scenario. I would recommend to switch to the ARPOW model.

I find it useful to be able to just set DotNetBuildFromSource while developing/testing/debugging without having my entire build wrapped by arcade.
It doesn't bring much complexity, and it makes the source-build configuration more accessible.

I think it's useful to have, and I'll self-support it (with some help from you).

@ViktorHofer ViktorHofer merged commit ed26344 into dotnet:main May 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DotNetBuildFromSource fail to compile src/libraries/shims/System.Data/ref/System.Data.csproj

2 participants