Account for PredefinedCulturesOnly in CultureInfo LCID .ctor #87002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.Globalization
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsFixes #86878
|
Contributor
Author
|
@dotnet-policy-service agree |
This was referenced Jun 1, 2023
tarekgh
reviewed
Jun 1, 2023
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs
Show resolved
Hide resolved
Member
|
@OwnageIsMagic could you please add a test case in the file https://github.com/dotnet/runtime/blob/main/src/libraries/System.Globalization/tests/Invariant/InvariantMode.cs? |
tarekgh
added
the
needs-author-action
ghost
removed
the
needs-author-action
tarekgh
reviewed
Jun 2, 2023
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs
Show resolved
Hide resolved
Member
|
@OwnageIsMagic I left a small suggestion, LGTM otherwise. |
tarekgh
approved these changes
Jun 2, 2023
Contributor
Author
|
@tarekgh Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86878