You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test validates that single-file probing is able to find its embedded resource assemblies. It is currently relying on running chcp to set the code page to UTF8 before launching the single-file app - which doesn't seem to always work (I'm not sure why - maybe something else sets it in between). We could have the app explicitly set the Console.Output.Encoding and then have the test set the ProcessStartInfo.StandardOutputEncoding, but the encoding is irrelevant to the actual test, so I figured it would just be noise and instead we'd avoid depending on it by switching the values in the resource to be ASCII.
The test validates that single-file probing is able to find its embedded resource assemblies. It is currently relying on running chcp to set the code page to UTF8 before launching the single-file app - which doesn't seem to always work (I'm not sure why - maybe something else sets it in between). We could have the app explicitly set the Console.Output.Encoding and then have the test set the ProcessStartInfo.StandardOutputEncoding, but the encoding is irrelevant to the actual test, so I figured it would just be noise and instead we'd avoid depending on it by switching the values in the resource to be ASCII.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
The test validates that single-file probing is able to find its embedded resource assemblies. It is currently relying on running
chcpto set the code page to UTF8 before launching the single-file app - which doesn't seem to always work (I'm not sure why - maybe something else sets it in between). We could have the app explicitly set theConsole.Output.Encodingand then have the test set theProcessStartInfo.StandardOutputEncoding, but the encoding is irrelevant to the actual test, so I figured it would just be noise and instead we'd avoid depending on it by switching the values in the resource to be ASCII.FIxes #85993