Skip to content

Fix reading runtime settings early in startup #87205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 2 commits into from
Jun 7, 2023
Merged

Fix reading runtime settings early in startup #87205

MichalStrehovsky merged 2 commits into from
Jun 7, 2023

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Jun 7, 2023

  • Since runtime settings are read before we had a chance to run dehydration, they cannot go to the dehydrated section. This is a 48-byte penalty per setting on Linux. Hopefully we won't have too many of these.
  • Fix the repro project to enable dehydration. When testing the original change, I used repro project where this worked because of no dehydration. We should mirror the shipping configuration.
  • Add a regression test. Picked a random test as a "victim" so that we don't unnecessarily regress testing time.

Cc @dotnet/ilc-contrib

@MichalStrehovsky
Fix reading runtime settings early in startup
71c07e1 
* Since runtime settings are read before we had a chance to run dehydration, they cannot go to the dehydrated section. This is a 48-byte penalty per setting on Linux. Hopefully we won't have too many of these.
* Fix the repro project to enable dehydration. When testing the original change, I used repro project where this worked because of no dehydration. We should mirror the shipping configuration.
* Add a regression test. Picked a random test as a "victim" so that we don't unnecessarily regress testing time.
@ghost ghost assigned MichalStrehovsky Jun 7, 2023
@ghost
Copy link

ghost commented Jun 7, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Since runtime settings are read before we had a chance to run dehydration, they cannot go to the dehydrated section. This is a 48-byte penalty per setting on Linux. Hopefully we won't have too many of these.
  • Fix the repro project to enable dehydration. When testing the original change, I used repro project where this worked because of no dehydration. We should mirror the shipping configuration.
  • Add a regression test. Picked a random test as a "victim" so that we don't unnecessarily regress testing time.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@MichalStrehovsky
Maybe fix Linux?
62021cd 
```
ld.lld(0,0): error : relocation R_X86_64_64 cannot be used against symbol 'g_compilerEmbeddedKnobsBlob_key_3'; recompile with -fPIC [/__w/1/s/src/tests/nativeaot/CustomMain/CustomMain.csproj]
```
@build-analysis build-analysis bot mentioned this pull request Jun 7, 2023
Closed
@MichalStrehovsky MichalStrehovsky merged commit d0c2515 into dotnet:main Jun 7, 2023
@MichalStrehovsky MichalStrehovsky deleted the settings branch June 7, 2023 23:40
@Maoni0 Maoni0 mentioned this pull request Jun 9, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky @vitek-karas